Special characters? Too same strings doesnt match...

[Lionlev]

Ok so I've go another problem. I've got a java socket multithread server and a flash client

When client clicks on login button, it sends this string <<user123 pass123>> server receives it and sort it to strings username = user123 and userpass = pass123
After that it checks if "user123" ini file exist in the src folder (username + ".ini") it finds it and reading it. user123.ini contains "password pass123"

and checks if userpass == user123's password
But the problem is that when I type the right password , it doesn't match it I don't know why...

Here is the code:

try
			{
				INPUT = new Scanner(SOCK.getInputStream());
				OUT = new PrintWriter(SOCK.getOutputStream());
				Scanner checkUser = null;
				boolean gotusername = false;
				boolean gotpassword = false;
				boolean goteverything = false;
				boolean allowmenu = false;
				boolean gotinmenu = false;
				String username = "NotFound";
				String userpassword = "NotFound";
				while(true)
				{
					CheckConnection();
					if(!INPUT.hasNext())
					{ return;}
					
					if(goteverything == false)
					{
						username = INPUT.next();
						userpassword = INPUT.next();
						System.out.println("User's username: " + username +"\n" + "User's password: " + userpassword);
						goteverything = true;
					}
					
					File userFile=new File(username+".ini");
					//File userFile=new File("lionlev.ini");
					System.out.println("looking for " + userFile);
					boolean exists = userFile.exists();
					if(!exists){
						System.out.println("Invalid username.");
					} else {
						try
						{
							checkUser = new Scanner(new File(username+".ini"));
							//checkUser = new Scanner(new File("lionlev.ini"));
						} catch (Exception e) {}
						checkUser.next();
						String cpass = checkUser.next();
						System.out.println("Entered pass: " + userpassword);
						System.out.println("REal pass: " + cpass);
						if(allowmenu == false){
							if(userpassword == cpass){
							System.out.println("Login is alright, sending "+username+ " to the menu..");
							OUT.println("ok1" + EOF);
							OUT.flush();
							allowmenu = true;
							} else{
								System.out.println("Wrong password");
							}
						} else {
							System.out.println("allowmenu is true");
						}
					}
					
					
					
					String menu1 = INPUT.next();
					while (gotinmenu == false){
						if(menu1.indexOf("menu") > -1){
							System.out.println("User "+username+ " is in the menu.");
							gotinmenu = true;
						}
					}

PLease help?

[Lionlev]

Maybe I am guessing that there are some extra hidden characters? I don't know...

[Fubarable]

First try calling trim() on the received String to remove leading and trailing white space. If that doesn't help, loop through each character of the received String to see for yourself exactly what you're receiving. Having said all of that, all the usual warnings about not using Strings for passwords, and for holding password Strings on disk apply.

[JosAH]

				if(userpassword == cpass)

That's not how you compare two Strings for equality; use the Striing.equals( ... ) method instead.

kind regards,

Jos

[Lionlev]

That's not how you compare two Strings for equality; use the Striing.equals( ... ) method instead.

kind regards,

Jos

Thanks!

[Tolls]

if(goteverything == false)

should be

if(!goteverything)

as you did with the later 'if' statement.

[Lionlev]

if(goteverything == false)

should be

if(!goteverything)

as you did with the later 'if' statement.

But isn't that the same thing?

[JosAH]

But isn't that the same thing?

Conceptually they are the same, but your version is more like:

if (a+1 > b+1) ...

... where a simpler:

if (a > b) ...

... can do the job too.

kind regards,

Jos

[Tolls]

But isn't that the same thing?

It just looks like you don't know what you're doing.