Problem with scope

I need help with a scope problem. Here is my code.

Code:

---

public class someClass implements KeyListener {

int px = 300;
int py = 200;
Player p1 = new Player();

public someClass () {
// Jframe made here
jframe.add(p1);
p1.setBounds(px, py, 45, 50);
}

public void keyPressed (KeyEvent e) {
px += 50;
p1.setBounds(px, py, 45, 50);
}

}

---

Ok well I want to move the p1 object with a keyPressed event. It compiles but it seems to be out of scope. Any way on how to fix this?

Note: I know this isn't valid code, but I just want to get the idea across.

What do you mean by "it seems to be out of scope"? There are no scope issues in the code posted.

When I call the Method with the keypressed event, the object dosen't move.

By habit I blame scope.

Quote:

---

Originally Posted by jlennards

When I call the Method with the keypressed event, the object dosen't move.

By habit I blame scope.

---

It's not really a scope issue but likely a reference issue or a focus issue. For a KeyListener to work, the component it is listening to must have focus. You can check to see if your key listener is active by adding some System.out.println statements in it and see if they print. If the KeyListener is working well, then again your issue could be one of reference -- that you're moving a Player object, but just not the currently visualized Player object. Understand that every time you call new Player(), you are creating a new and distinct Player object. If you want this class to act on a Player object that has been created elsewhere, you'll need to pass a reference of that Player object into this class, perhaps as the parameter of a setPlayer method.

Quote:

---

Originally Posted by Fubarable

It's not really a scope issue but likely a reference issue or a focus issue. For a KeyListener to work, the component it is listening to must have focus. You can check to see if your key listener is active by adding some System.out.println statements in it and see if they print. If the KeyListener is working well, then again your issue could be one of reference -- that you're moving a Player object, but just not the currently visualized Player object. Understand that every time you call new Player(), you are creating a new and distinct Player object. If you want this class to act on a Player object that has been created elsewhere, you'll need to pass a reference of that Player object into this class, perhaps as the parameter of a setPlayer method.

---

Can anyone tell me how to do that?

Quote:

---

Originally Posted by jlennards

Can anyone tell me how to do that?

---

I thought I just did:

Quote:

---

Originally Posted by Fubarable

If you want this class to act on a Player object that has been created elsewhere, you'll need to pass a reference of that Player object into this class, perhaps as the parameter of a setPlayer method.

---

If anything confuses you, then ask please. Of course the details of your specific solution will depend on your program structure, but play around with it a bit and see what you can come up with.

Looks like i will have to get creative. Thanks.