making mouse movements human like [help]

[crikey]

Robot robot;
		MouseInfo i = null;
		
		try {
			int preX = i.getPointerInfo().getLocation().x;
			int preY = i.getPointerInfo().getLocation().y;
			scanning:
			while (preX != x && preY != y){
				if (preX == x){
					
				}
				else if (preX > x){
					preX = preX-4;
				}
				else if (preX < x){
					preX = preX+4;
				}
				if (preY == y){
					
				}
				else if (preY > y){
					preY = preY-4;
				}
				else if (preY < y){
					preY = preY+4;
				}
				if (preY == y && preX == x){
					break scanning;
				}
				robot = new Robot();
				int rnd = Methods.random(1,500);
				if (rnd == 5){
					robot.mouseMove(preX+2, preY+3);
					robot.delay(Methods.random(500, 600));
					preX = preX + 1;
					preY = preY + 1;
				}
			
			robot.mouseMove(preX, preY);
			robot.delay(Methods.random(10, 15));
			}
		} catch (AWTException e) {

			e.printStackTrace();
		}

I am trying to make a mouse movement human-like, because the normal robot class is extremely un-human. When i try to run the above code, the mouse does not move to the right location, and is awfully buggy. Any tips? Thanks!

[Norm]

When i try to run the above code, the mouse does not move to the right location, and is awfully buggy

Can you describe what happens?

What is the "right location" as compared to the location where the cursor is moved to?
Above, below, to left, to right???

[crikey]

Thanks Norn for your reply-
I forgot to include that this was a method that you can call like this:
moveMouse(int x, int y);
So the "right location" in this case are the parameters passed on to the method. For example, i pass on the parameters to be '500,500'; The method should move the mouse to that spot. Instead, the mouse path unpredictably moves.

[Norm]

the mouse path unpredictably moves

Hard to believe.
Does the cursor move to a new unique place every time you use 500, 500?
Or does it move to the same place every time?

[crikey]

Hard to believe.
Does the cursor move to a new unique place every time you use 500, 500?
Or does it move to the same place every time?

It moves to some random place, that is clearly not 500,500.

[toadaly]

I don't see anything that guarantees the mouse will ever stop moving and end up where you want it in any reasonable number of time. In your while loop, you are always adding or subtracting 4, except when you enter the random portion and you add 1. Given enough time (on the order of minutes it looks like), it should eventually hit the right spot as long as nothing else changes the pointer location. My guess is you are calling this method from multiple threads that are all trying to move the pointer around and interfereing with eachother.

[crikey]

I don't see anything that guarantees the mouse will ever stop moving and end up where you want it in any reasonable number of time. In your while loop, you are always adding or subtracting 4, except when you enter the random portion and you add 1. Given enough time (on the order of minutes it looks like), it should eventually hit the right spot as long as nothing else changes the pointer location. My guess is you are calling this method from multiple threads that are all trying to move the pointer around and interfereing with eachother.

Thanks for your reply-
This is not the case though, as this is all ran on a single thread. There is only one instance where i run it.

[Norm]

Does the cursor move to a new unique place every time you use 500, 500?
Or does it move to the same place every time given the 500, 500 location?

robot.mouseMove(preX+2, preY+3);

What are the values of preX+2 and preY+3?

[crikey]

Does the cursor move to a new unique place every time you use 500, 500?
Or does it move to the same place every time given the 500, 500 location?

robot.mouseMove(preX+2, preY+3);

What are the values of preX+2 and preY+3?

It moves to a unique, new place every time. And that there is the human like feature to make it look like it is not moving in a perfectly strait line every once in a while.

The values of preX and preY are both the mouse positions (preX = current x, preY = currentY). So preX is the current mouse position + 2, and preY is +3.

[Norm]

It moves to a unique, new place every time.

That's interesting. Computers usually do the same thing with the same input data, but you say your program moves the cursor to a different place every time it is given 500,500.

What are the values of preX+2 and preY+3?

Can you make a small program and post it that compiles and executes that demonstrates this?

[crikey]

Okay, it looks like it works now. Just one little problem now:
When the mouse gets very close to the 500,500 spot, it moves around crazily because of the random function i put into there

[Norm]

it moves around crazily because of the random function i put into there

Remove/fix your code.

[crikey]

Very strange. Even when i remove it, it still "spazzes" out.

[crikey]

Okay, here is the complete method source:

	public void moveTo(int x, int y) {
		Robot robot;
		MouseInfo i = null;
		
		try {
			int preX = i.getPointerInfo().getLocation().x;
			int preY = i.getPointerInfo().getLocation().y;
			scanning:
			while (preX != x && preY != y){
				
				 preX = i.getPointerInfo().getLocation().x;
				 preY = i.getPointerInfo().getLocation().y;
				
				if (preX == x){
					
				}
				
				if (preX != x && preY == y && preX > x){
					preX = preX - 2;
				}
				else if (preX != x && preY == y && preX < x){
					preX = preX + 2;
				}
				else if (preY != y && preX == x && preY < x){
					preY = preY + 2;
				}
				else if (preY != y && preX == x && preY > x){
					preY = preY -2;
				}
				else if (preX > x){
					preX = preX-2;
				}
				else if (preX < x){
					preX = preX+2;
				}
				if (preY == y){
					
				}
				else if (preY > y){
					preY = preY-2;
				}
				else if (preY < y){
					preY = preY+2;
				}
				if (preY == y && preX == x){
					System.out.println("hit");
					break scanning;
				}
				robot = new Robot();
				
			
			robot.mouseMove(preX, preY);
			robot.delay(Methods.random(10, 15));
			}
		} catch (AWTException e) {

			e.printStackTrace();
		}

	}

[Norm]

I don't understand how the code you posted can work:

MouseInfo i = null;
		
		try {
			int preX = i.getPointerInfo().getLocation().x;

Do you get a NPE because i is null?

[crikey]

Actually, it works. It does the job that i need it to (returns to mouse position). So setting it null doesn't effect it...for as far as i know.

[Norm]

Actually, it works.

I don't believe the code you posted will work without getting a NPE.
Calling a method using a null variable can't work.

[crikey]

You should try it. But in the meantime, how should i fix it?

[Norm]

Yes it works. I didn't lookup the methods to see they were static.
Clearer coding would prevent others from misreading your code:

int preX = MouseInfo.getPointerInfo().getLocation().x; // use normal static method ref

[crikey]

Oh okay. It works better now! But, there is still a major issue: It does not always go to the right place.