JMF player.setSource

[lambi]

Ok, so maybe i'm an idiot and the solution is right in front of me and i can't figure it out, but for the life of me i can't get this to work the way i want.

I'm coding a simple audio player which is supposed ot read the contents of a folder, and then play the contents (currently in order, to be changed later). But for whatever reason, i can't get my player to accept a new source...

public class Library {

    static AudioFile f;
    static Tag tag;
    static String[] names;
    static URL[] links;
    static Player player;

    public static void main(String[] args) {

        File lib = new File("E:/MediaLibrary/music");
        System.out.println(lib);
        List<File> list = new ArrayList<File>();
        getLinks(lib, list);
        System.out.println(names.length);
        for (int i = 0; i < names.length; i++) {
            System.out.println("Name:" + names[i]);
            System.out.println("Link: " + links[i].toString());
        }
        createPlayer(links[0]);
        System.out.println(player.getState());
    }

    private static void createPlayer(URL link) {
        player = Manager.createPlayer(link);
        player.start();
        player.addControllerListener(new EventHandler());
    }

    private static void getLinks(File folder, List<File> list) {
        folder.setReadOnly();
        File[] files = folder.listFiles();
        names = new String[files.length];
        links = new URL[files.length];
        for (int j = 0; j < files.length; j++) {
            if (files[j].isDirectory()) {
                getLinks(files[j], list);
            } else {
                list.add(files[j]);
            }
        }
        for (int x = 0; x < list.size(); x++) {
                f = AudioFileIO.read(list.get(x));
                tag = f.getTag();
                names[x] = tag.getFirst(FieldKey.ARTIST);
                links[x] = list.get(x).toURL();
        }
    }

    private static class EventHandler implements ControllerListener {

        public void controllerUpdate(ControllerEvent event) {
            if (event instanceof EndOfMediaEvent) {
                player.deallocate();
                System.out.println("end of media");
                DataSource ds = null;
                ds = Manager.createDataSource(links[1]);
                player.setSource(ds);
                player.start();
                System.out.println("player started");
            }
        }
    }
}

(omitted: a whole bunch of jaudiotagger-stuff which i use to read the id-tags, as well as all the try-catch blocks needed for DataSources, URLs etc.)

Now, everything that happens is that the first song in the directory (as saved in links[0]) gets played over and over again. Defining a new DataSource with

                ds = Manager.createDataSource(links[1]);
                player.setSource(ds);

just does not seem to work. Only workaround so far is simply closing the player and opening a new one with the next link

                player.deallocate();
                player.close();
                createPlayer(links[1]);

But i don't like it as it just calls for memory leaks or something like that. And if there's the possibility to set a new datasource, why not use it?
Anyone has a solution / hint where i'm wrong?

[FON]

In EventHandler you could try this try this instead:

player = javax.media.Manager.createPlayer(links[1]);

so now second songs will be played.

I removed:

 DataSource ds = null;
 ds = Manager.createDataSource(links[1]);
 player.setSource(ds);

I have no knowledge of this API
and is it wise to call twice Manager.createPlayer
or should it be done with DataSource like you did,
but i've got two songs playing not one for two times

was this helpful?

[lambi]

Well, it basically does the same as my workaround. Except in your solution we're reusing the same player object, which probably is better than instancing a new one as i did. And it seems to work just fine, judging from the memory footprint, all the memory used by the player gets properly freed up on media change, so no memory leak there. So, even if it's not as "elegant" is it could be, it works well enough.
Thanks.