Java optimization

[Raymond]

Why is that? I dont really understand. I allocated 2k +.

[Tolls]

Why is what?
Could you please phrase a full and detailed question, because I am now lost as to what you're asking about.

[masijade]

Oh <pause> My <pause> God! Not Again!

See this

Edit: You have no idea what you're doing and are in completely over your head. You got some game from somewhere that doesn't run quite how you'd like it to, if at all, and you're looking for some "silver bullet" solution to turn it into a "workhorse". Well, here's your solution, get a computer with about 64 3 GHz Quad-4 CPU's with hardware threads, and about 100 Gb memory. Then start the server with "-server -d64 -Xms25000m -Xmx100000m".

[Raymond]

Basically how to make the source codes more faster like uses lesser RAM?

[Tolls]

Blimey.
I forgot about that thread.

Look, Raymond...there is no "go faster" magic to Java. You need to go through your code and figure out where it's going wrong...or slow...or whatever requirement you have that it's failing to do.

So, please...stop posting these sorts of questions because there is no answer!

[Raymond]

I think I get deadlocks here:

public static MapleStorage loadOrCreateFromDB(int id) {
MapleStorage ret = null;
int storeId;
try {
Connection con = DatabaseConnection.getConnection();
PreparedStatement ps = con.prepareStatement("SELECT * FROM storages WHERE accountid = ?");
ps.setInt(1, id);
ResultSet rs = ps.executeQuery();
if (!rs.next()) {
rs.close();
ps.close();
return create(id);
} else {
storeId = rs.getInt("storageid");
ret = new MapleStorage(storeId, (byte) rs.getInt("slots"), rs.getInt("meso"));
rs.close();
ps.close();
String sql = "SELECT * FROM inventoryitems " + "LEFT JOIN inventoryequipment USING (inventoryitemid) " + "WHERE storageid = ?";
ps = con.prepareStatement(sql);
ps.setInt(1, storeId);
rs = ps.executeQuery();
while (rs.next()) {
MapleInventoryType type = MapleInventoryType.getByType((byte) rs.getInt("inventorytype"));
if (type.equals(MapleInventoryType.EQUIP) || type.equals(MapleInventoryType.EQUIPPED)) {
int itemid = rs.getInt("itemid");
Equip equip = new Equip(itemid, (byte) rs.getInt("position"), rs.getInt("ringid"));
equip.setOwner(rs.getString("owner"));
equip.setQuantity((short) rs.getInt("quantity"));
equip.setAcc((short) rs.getInt("acc"));
equip.setAvoid((short) rs.getInt("avoid"));
equip.setDex((short) rs.getInt("dex"));
equip.setHands((short) rs.getInt("hands"));
equip.setHp((short) rs.getInt("hp"));
equip.setInt((short) rs.getInt("int"));
equip.setJump((short) rs.getInt("jump"));
equip.setLuk((short) rs.getInt("luk"));
equip.setMatk((short) rs.getInt("matk"));
equip.setMdef((short) rs.getInt("mdef"));
equip.setMp((short) rs.getInt("mp"));
equip.setSpeed((short) rs.getInt("speed"));
equip.setStr((short) rs.getInt("str"));
equip.setWatk((short) rs.getInt("watk"));
equip.setWdef((short) rs.getInt("wdef"));
equip.setUpgradeSlots((byte) rs.getInt("upgradeslots"));
equip.setLocked((byte) rs.getInt("locked"));
equip.setLevel((byte) rs.getInt("level"));
ret.items.add(equip);
} else {
Item item = new Item(rs.getInt("itemid"), (byte) rs.getInt("position"), (short) rs.getInt("quantity"), rs.getInt("petid"));
item.setOwner(rs.getString("owner"));
ret.items.add(item);
}
}
rs.close();
ps.close();
}
} catch (SQLException ex) {
log.error("Error loading storage", ex);
}
return ret;
}

[masijade]

<Knock><Knock><Knock>Hello! <pause> Is there anybody home!? <pause> (thinks to self as leaving) well, the lights are on, but there doesn't seem to be anybody home.


P.S. This is a perfect case-in-point. There is absolutely no synchronization involved there, so why, in the heck, do you think that there even might be a deadlock issue there? Just thought I'd illuminate that fact, and this point, and I will leave it at that, now.

[Tolls]

You "think"?
You can't mistake a deadlock because...well...it deadlocks.

And you really need to format your code.

[Raymond]

Everytime it loads or create my server crashes. I wonder why ;)

[masijade]

Everytime it loads or create my server crashes. I wonder why ;)

Let me get this straight, so you think the method called "loadOrCreateFromDB" is what "loads or creates your Server"?

We need go no further than this.

[JosAH]

Bitrot, it's definitely bitrot; does your server smell like fungi? If so, it's bitrot.

kind regards,

Jos ;-)

[r035198x]

while(true) { 
    headDesk++;
    faceDesk++;
}

is an example of code that will crash several things.