A difficult question - efficient coding?

[tyang]

Can anyone tell me whether the following code is efficient or not?
Thank you very much!


import java.io.*;
import java.util.*; //needed for StringTokenizer
public class Knn
{
public static void main(String args[])
throws java.io.IOException
{
String fileName, inLine;
int i, j, numInstance, numFeature;
double dat[][] = new double[150][4];
StringTokenizer st;

InputStreamReader isr = new InputStreamReader(System.in);
BufferedReader br = new BufferedReader(isr);
System.out.print("Please enter the file name:");
fileName = br.readLine() + ".txt";
System.out.print("Please enter the number of instances:");
numInstance = Integer.parseInt(br.readLine());
System.out.print("Please enter the number of features:");
numFeature = Integer.parseInt(br.readLine());

br.close();

BufferedReader fi = new BufferedReader(new FileReader(fileName));
for (i = 0; i<numInstance; i++)
{
inLine = fi.readLine();
st = new StringTokenizer(inLine);
for (j = 0; j<numFeature; j++)
{
dat[i][j] = Double.parseDouble(st.nextToken());
}
System.out.println(dat[i][0]);
}
fi.close();


}




}//end class Knn

[Fubarable]

What do you mean by "efficient"? Also, please edit your post above and add code tags (please see my signature below).

[Tolls]

Couldn't say since I have no idea what you're trying to achieve (and it's very difficult to read unformatted code). Or, as Fubarable says, any idea what you might mean by efficient.

[JosAH]

Can anyone tell me whether the following code is efficient or not?

As far as I can see the program reads n lines and m doubles per line; the values n and m are supplied by the user. The entire program is bound by the IO speed, so speed tests are out of the question. The user IO is very fragile (if the user types nonsense or incorrect values for n and m the entire thing dies a horrible death). If n and m and the file contents are correct the program does its job though, too bad a fixed size two dimensional array was used.

kind regards,

Jos