this keyword possibly buggy with scopes ?

[Coral]

I have 3 classes, PosManager, Sim, Pos

I have over ridden the .equals method in the Sim class

I have used the "this" keyword , am I using it incorrectly ? Details follow below.

public boolean equals(Sim sim){
    if(!(sim == null && this == null)){
      if(this.getId().equals(sim.getId()))
        return false;
      else
        return true;
    }else if(sim == null && this == null){
      return true;
    }
  
    return false;
  
}

2nd line, is my invocation, instead it invokes the PosManager instance. The PosManager has a Pos which has a Sim, I call the getSim of the Pos object which returns the Sim, then the sim invokes .equals(Sim sim) <<the above method>> where I invoke "this" and it returns the PosManager Object instead. Though, when going in line 3, the methods/attributes are correctly given.

I recieved the information of the "this" instantiation being PosManager from eclipse, maybe it is at fault ? However when comparing 2 sims where the ID is the same , they return is if they were not the same.

To me this behaviour is incorrect as the this keyword should be the current instance of the class

Any help would be appreciated (regarding my question)

[Coral]

I do realise that you can't call this method from a null variable of type Sim class it is just a scenario, so if there is an instance of the sim calling this method , "this" behaves incorrectly

[Fubarable]

I recieved the information of the "this" instantiation being PosManager from eclipse, maybe it is at fault ? However when comparing 2 sims where the ID is the same , they return is if they were not the same.

If you are receiving a compiler or JVM error, what do you honestly believe the chances are that this is due to a bug in Java or Eclipse vs. the chances that it is a bug in your code?

1) Your equals method is not a true equals since its signature doesn't match that of Object's exactly (the parameter must be Object, not Sim).
2) The "this" object will never be null when this method is successfully called.
3) My equals methods often look similar to this:

   @Override
   public boolean equals(Object obj) {
      if (obj == null) {
         return false;
      }
      if (this == obj) {
         return true;
      }
      if (!(obj instanceof Sim)) {
         return false;
      }
      
      Sim otherSim = (Sim) obj;

      // if id is an object and not a primitive.  
      return id.equals(otherSim.getId());
      
      // if a primitive, then
      // return id == otherSim.getId();

   }

[Coral]

Thanks for the rapid response Fubarable

I understand about the null object as stated, and the rest of your points you have made
Thanks for that.

It was a semantic error that I had made :-/. (forgot an '!')

Yet it is still weird that eclipse tells me that "this" in that context appears as the incorrect class (only for the "watch" window that pops up when hovering over it)

You are welcome to delete this thread as the topic is rather derogatory :P
Sorry about that

[Fubarable]

Thanks for the rapid response Fubarable
I understand about the null object as stated, and the rest of your points you have made
Thanks for that.
It was a semantic error that I had made :-/. (forgot an '!')

You're most welcome. I'm glad that you figured it out.

Yet it is still weird that eclipse tells me that "this" in that context appears as the incorrect class (only for the "watch" window that pops up when hovering over it)

Without more code, it's hard to tell what Eclipse/Java is complaining about.

You are welcome to delete this thread as the topic is rather derogatory :P
Sorry about that

What do you mean derogatory? I see nothing inherently bad about this thread.

Much luck!