JUnit testing

[hedonist]

Hi, I am trying to run a JUnit test for the following code. But the assertEquals(0x2084, DataNetwork.getShort(data, 1));
is throwing an error, couldn't figure out. Any help would be highly appreciated.
Thanks

.........
byte[] data = new byte[] {(byte) 0x00, (byte) 0x20, (byte) 0x84};
assertEquals(0x2084, DataNetwork.getShort(data, 1));
............

public class DataNetwork {

        /**
	 * Get the byte in the specific offset.
	 */
	public static byte get(byte[] data, int offset) {
		return data[offset];
	}

	/**
	 * Get the short in the specific offset. 
	 */
	public static short getShort(byte[] data, int offset) {
		return (short) (get(data, offset) << 8 | get(data, offset + 1));
	}
}

[r035198x]

Print out the value of DataNetwork.getShort(data, 1) to see what it is then.

[hedonist]

I did and i get a value of -124. The getShort() function should have returned 132 which is the decimal representation of 0x84. Maybe it has to do something with converting the output of getShort() method to 'short' data type....I'm lost here.

[r035198x]

Why do you have that get method? All it does is easily done using data[offset]. No need for a method for that.

Did you work out (byte)0x20 | (byte)0x84 to see what the result is because that is what your call effectively says.
And yes, the cast to byte will truncate if the value is out of range for bytes.

[hedonist]

Thank you. You are right, I was trying out for [(byte)0x20 <<8| (byte)0x84]. I was searching why i was getting different answer and it seems that truncation to byte is the reason. I want to learn more about it..i googled about short data types but all it mentioned was, "short takes 16-bit 2's complementary......" not much helpful.