for loop not executing

[kirtichopra2003]

hi all i am trying the following code but for loop is not working with label and without label it is working fine.
Please let me know what mistake i am doing

outer:for(int i=0;i<sheet.getRows();i++)
{
Subscriber subscriber=new Subscriber();
for(int j=0;j<sheet.getColumns();j++)
{
Cell cell=sheet.getCell(j,i);
CellType type=cell.getType();
st=cell.getContents();

if(st!=null && (j==0)&& !st.contains("@"))
{
subscriber.setName(st.trim());
}
else
{
validationDisplay.append("Error on Row :"+i+" Column :"+j+", ");
continue outer;
}
}

[Tolls]

I've never used labels.
There's usually no need for them.

What does "is not working" actually mean?

Why not get rid of the label and simply use "break" instead of "continue" <label>?

[kirtichopra2003]

thanks for the reply i will try it
thankyou for the help!!

[Supamagier]

I've never used labels.
There's usually no need for them.

What does "is not working" actually mean?

Why not get rid of the label and simply use "break" instead of "continue" <label>?

Using labels can make your loops twice as fast (if you use'm correctly).
But... in this case, his continue is quite useless. ;)

[Tolls]

Twice as fast?
I somehow doubt that's the case, except maybe in the following:

boolean myflag = true;
mylabel: for  (int i = 0; i < 10; i++) {
    if (myflag) continue mylabel;
    System.out.println("I'm never going to get here");
}

...

[Dieter]

your example rox :p "i'm never going to get here"

[Supamagier]

What'ya think of this?

        final String[] sarray = {"A","B","C","A","A","B","D","E"};
        ArrayList<Integer> resultI = new ArrayList<Integer>();
        ArrayList<String> resultS = new ArrayList<String>();

L1:     for (int i = 0; i < sarray.length; ++i) {
            for (int j = 0; j < resultS.size(); ++j) {
                if (sarray[i].equals(resultS.get(j))) {
                    resultI.add(j);
                    continue L1;
                }
            }
            resultS.add(sarray[i]);
            resultI.add(resultS.size()-1);
        }

Without the continue you would have to add an if statement to check if for the 2 lines after the inner loop, you would have to use some kind of boolean and set it to true for the if after the inner loop. Next to that, if you find a correct value, you would still loop through the rest of the 'possible' matches (Assuming you don't use a break). On an average, you're next match will be in the middle, so you only have to loop to that, which is faster, than iterate through every element

So it is faster, and it saves some memory, using a label. (just a boolean, but who cares, xD)

[Tolls]

It might be faster and all that, but since I haven't the faintest what it's actually doing it's no more clever than my example.

ETA: Ah, I think I see now. So here you go:

        final String[] sarray = {"A","B","C","A","A","B","D","E"};
        List<String> stringlist = new ArrayList<String>();
        int[] locations = new int[sarray.length];
        
        for (int i = 0; i < sarray.length; ++i) {
        	int j = stringlist.indexOf(sarray[i]);
        	if (j == -1) {
        		stringlist.add(sarray[i]);
        		j = stringlist.size() - 1;
        	}
        	locations[i] = j;
        }

No labels, no overhead of ArrayList<Integer>, and all the implicit conversions therein, no internal loop (at least not by me) relying instead on the underlying logic of my List...

[Supamagier]

O.K.

You beat me. xD Yours is slightly faster. ^^

[Tolls]

I have absolutely no idea if it's faster (I suspect they're very similar).
But at least it doesn't have pseudo-gotos in it...
:)