problem with notepad

[munish]

i am having problem with this notepad i am not been able to open an dialog box when i click
open or save menuitems>

package eventhandling;
import java.awt.*;
import java.awt.event.*;
import java.io.*;
public class notepad {
    public static void main(String s[]){
        myframe f1=new myframe("Notepad");
        f1.setSize(400,400);
        f1.setVisible(true);
        f1.setLocation(400,400);
    }
}
class myframe extends Frame implements ActionListener{
    TextArea t1;
    String arg;
    myframe(String s){
        super(s);
        t1=new TextArea(20,30);
        setLayout(new BorderLayout());
        add(t1,BorderLayout.CENTER);
        MenuBar mb1=new MenuBar();
        setMenuBar(mb1);
        Menu file=new Menu("File");
        MenuItem open =new Menu("Open");
        MenuItem save=new Menu("Save");
        file.add(open);
        file.add(new MenuItem("_"));
        file.add(save);
        Menu edit=new Menu("Edit");
        MenuItem cut=new Menu("Cut");
        file.add(new MenuItem("_"));
        MenuItem copy=new Menu("Copy");
        MenuItem paste=new Menu("Paste");
        open.addActionListener(this);
        save.addActionListener(this);
        edit.add(cut);
        edit.add(copy);
        edit.add(paste);
        mb1.add(file);
        mb1.add(edit);
        
    }
    public void actionPerformed(ActionEvent e)
    {
        String command=e.getActionCommand();
        System.out.println(command);
        arg="you selected"+command;
        t1.append(arg + "\n");
        if(command.equals("Open"))
        {
            FileDialog fd;
            Frame f1=new Frame();
            fd=new FileDialog(f1,"open the file");
            fd.setSize(300,300);
            fd.setVisible(true);
            fd.setLocation(400,400);
            t1.append("you selected"+fd.getDirectory()+fd.getFile());
            try
            {
                FileReader fr=new FileReader(fd.getDirectory()+fd.getFile());
                String msg="";
                int i;
                while((i=fr.read())!=-1)
                {
                    msg=msg+(char)i;
                }
                fr.close();
                t1.append(msg);
            }catch(Exception ex){}
        }
        if(command.equals("Save")){
            FileDialog fd;
            Frame f1=new Frame();
            fd=new FileDialog(f1,"save the file",FileDialog.SAVE);
            fd.setSize(300,300);
            fd.setVisible(true);
            fd.setLocation(400,400);
            try{
                FileWriter fr=new FileWriter(fd.getDirectory()+fd.getFile());
                fr.write(t1.getText());
                fr.close();
            }catch(Exception ex){}

        }
    }
}

[r035198x]

Don't do

 catch(Exception ex){}

that just hides the possible exceptions.
At least do a

catch(Exception ex){ex.printStackTrace();}

so you know what exceptions if any have occurred.
Also add a window listener for your frame so that users can close it if they wish to.
Format your code and post it wrapped under code tags.

[pbrockway2]

What (if anything) is being printed on System.out when you select the save or open menu items?

Your code would be easier to read if you put [code] at the start of the code and [/code] at the end. Or select your code and click the # button.

[munish]

thanks for rply >>>.

nothing prints on system .out when i click open or save..................

[r035198x]

The reason why the actions don't fire is because you created new Menu objects not MenuItem objects. The references are type MenuItem but the object itself is a Menu.
Menu will only send the event to the frame when one of its subitems is selected.

Change the lines

MenuItem open =new Menu("Open");

to

MenuItem open =new MenuItem ("Open");

[munish]

thank u that was very silly mistake???????????????

[r035198x]

Welcome, it helps to read the API specs for those classes as well.
Any particular reason why you are using awt instead of swing.

[munish]

i just started with java few months ago i am going step by step to higher concepts